Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2668

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #2668

wants to merge 2 commits into from

Conversation

mgsorigo
Copy link

@mgsorigo mgsorigo commented Nov 4, 2024

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! you perfectly replicated design for specific screen sizes but you also need to add responsiveness between breakpoints to create smoother transitions and make better use of space
margins expand rather than the content which disrupts proportions:
image

e.g. navigation bar could expand proportionally to screen width maintaining fixed margins and increasing space between elements
image

@mgsorigo
Copy link
Author

mgsorigo commented Nov 4, 2024

Great work! you perfectly replicated design for specific screen sizes but you also need to add responsiveness between breakpoints to create smoother transitions and make better use of space margins expand rather than the content which disrupts proportions: image

e.g. navigation bar could expand proportionally to screen width maintaining fixed margins and increasing space between elements image

@natalia-klonowska check my https://mgsorigo.github.io/layout_miami/

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you forgot to commit your changes? cos previous issue is not fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants